Return-path: Received: from mail-lb0-f178.google.com ([209.85.217.178]:37518 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbaKYUKl (ORCPT ); Tue, 25 Nov 2014 15:10:41 -0500 Received: by mail-lb0-f178.google.com with SMTP id f15so1378847lbj.9 for ; Tue, 25 Nov 2014 12:10:39 -0800 (PST) Message-ID: <5474E23C.8090208@cogentembedded.com> (sfid-20141125_211047_961395_86DD772A) Date: Tue, 25 Nov 2014 23:10:36 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Larry Finger , linville@tuxdriver.com CC: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Valerio Passini Subject: Re: [PATCH 1/2 V2 3.18] rtlwifi: rtl8821ae: Fix 5G detection problem References: <1416945727-10743-1-git-send-email-Larry.Finger@lwfinger.net> In-Reply-To: <1416945727-10743-1-git-send-email-Larry.Finger@lwfinger.net> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 11/25/2014 11:02 PM, Larry Finger wrote: > The changes associated with moving this driver from staging to the regular > tree missed one section setting the allowable rates for the 5GHz band. > This patch is needed to fix the regression reported in Bug #88811 > (https://bugzilla.kernel.org/show_bug.cgi?id=88811). > Reported-by: Valerio Passini > Tested-by: Valerio Passini > Signed-off-by: Larry Finger > Cc: Valerio Passini > --- > V2 - removed extra parentheses as suggested by John Linville. He's also suggested spaces around << in his example > --- > drivers/net/wireless/rtlwifi/rtl8821ae/hw.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c > index 310d316..18f34f7 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8821ae/hw.c > @@ -3672,8 +3672,9 @@ static void rtl8821ae_update_hal_rate_mask(struct ieee80211_hw *hw, > mac->opmode == NL80211_IFTYPE_ADHOC) > macid = sta->aid + 1; > if (wirelessmode == WIRELESS_MODE_N_5G || > - wirelessmode == WIRELESS_MODE_AC_5G) > - ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ]; > + wirelessmode == WIRELESS_MODE_AC_5G || > + wirelessmode == WIRELESS_MODE_A) > + ratr_bitmap = sta->supp_rates[NL80211_BAND_5GHZ]<<4; The kernel style generally assumes spaces around operators, and it would only be consistent with the other code in the vicinity if you added them... WBR, Sergei