Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:35631 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbaKYT2U (ORCPT ); Tue, 25 Nov 2014 14:28:20 -0500 Message-ID: <5474D852.9020504@broadcom.com> (sfid-20141125_202823_652790_BEA3A502) Date: Tue, 25 Nov 2014 20:28:18 +0100 From: Arend van Spriel MIME-Version: 1.0 To: "John W. Linville" CC: linux-wireless Subject: Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs References: <1416518822-29585-1-git-send-email-arend@broadcom.com> <1416518822-29585-4-git-send-email-arend@broadcom.com> <20141124215049.GA4484@tuxdriver.com> <54747232.3030503@broadcom.com> <20141125184945.GD15476@tuxdriver.com> <20141125190533.GH15476@tuxdriver.com> <5474D581.5010909@broadcom.com> <5474D72B.1090101@broadcom.com> In-Reply-To: <5474D72B.1090101@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/25/14 20:23, Arend van Spriel wrote: > On 11/25/14 20:16, Arend van Spriel wrote: >> On 11/25/14 20:05, John W. Linville wrote: >>> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote: >>>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote: >>>>> On 11/24/14 22:50, John W. Linville wrote: >>>>>> Hmmm...I'm not sure why, but this is causing problems for me... >>>>>> >>>>>> ERROR: "brcmu_boardrev_str" >>>>>> [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined! >>>>> >>>>> I am confused as well. I did not have such an issue. The function is >>>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and >>>>> added it >>>>> to the include file. Missing something? Also I don't see this issue >>>>> over >>>>> here. I will do a clean build on the wireless-next tree and see if I >>>>> can >>>>> reproduce this. >>>> >>>> I did a clean build after applying the patches in question, and I >>>> still got the same issue at link time. I'll attach my .config for >>>> you to try. >>> >>> I think that was too big...trying the compressed version... >> >> I received both. I assume he commit mentioned below is without the >> patches. > > Nevermind. Just saw that commit is before the reverts. Crap. I unintentionally put the function in #ifdef section. Will fix that and send a v2 patch. Regards, Arend > Thanks, > Arend > >> Regards, >> Arend >> >>>> FWIW, I am building wireless-testing at commit >>>> 733ea24c8c98d99c747b89710e520ac6e9f3951b. >>> >>> John >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-wireless" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html