Return-path: Received: from arrakis.dune.hu ([78.24.191.176]:45735 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbaKLL0n (ORCPT ); Wed, 12 Nov 2014 06:26:43 -0500 Message-ID: <546343EF.5090803@openwrt.org> (sfid-20141112_122647_180113_0C39602E) Date: Wed, 12 Nov 2014 12:26:39 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Sujith Manoharan , John Linville CC: linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com Subject: Re: [PATCH 1/6] ath9k: disable overriding AR9340 SLP32 registers References: <1415689644-29693-1-git-send-email-sujith@msujith.org> <1415689644-29693-2-git-send-email-sujith@msujith.org> In-Reply-To: <1415689644-29693-2-git-send-email-sujith@msujith.org> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2014-11-11 08:07, Sujith Manoharan wrote: > From: Miaoqing Pan > > For AR9340, the correct values for SLP32 registers are present > in the initvals, so overriding them is not needed. > > Signed-off-by: Miaoqing Pan > Signed-off-by: Sujith Manoharan What's the point in doing this? The writes don't hurt, and this change is making the code uglier. - Felix