Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:51220 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbaKYOSN (ORCPT ); Tue, 25 Nov 2014 09:18:13 -0500 Message-ID: <1416925085.2045.7.camel@sipsolutions.net> (sfid-20141125_151821_011194_2260EBE7) Subject: Re: [PATCH] mac80211: check if channels allow 80 MHz for VHT probe requests From: Johannes Berg To: YanBo Cc: linux-wireless Date: Tue, 25 Nov 2014 15:18:05 +0100 In-Reply-To: (sfid-20141125_151401_364139_C8F262C6) References: <1416911009-22405-1-git-send-email-johannes@sipsolutions.net> <1416913453.2045.4.camel@sipsolutions.net> <1416917279.2045.5.camel@sipsolutions.net> (sfid-20141125_151401_364139_C8F262C6) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2014-11-25 at 22:13 +0800, YanBo wrote: > > But is all of that really the right way? I'm not completely convinced. > > Except set the flag, the HW itself should support this feature, or > else it also doesn't work, I'd > send the patch in soon for public review. Yeah, but is it really the right way to advertise VHT? In the spec, VHT means you also have 80 MHz support - do you really think you can/will do 80 MHz on 2.4 GHz? Seems like all of this will cause more corner cases. > > > > I guess we can make this check conditional for 5GHz when the VHT support > > lands and is discussed. > > > That is sounds good if it only check for 5GHz for what I know CMIIW. Even on 2.4 GHz it technically isn't enough though - there's enough spectrum in 2.4 GHz for a single 80 MHz channel; how long until somebody wants to do *that* for some reason? But the rest of us really doesn't think that's applicable ... Anyway, it probably needs mac80211 patches anyway since mlme.c already disables VHT if you can't do 80 MHz, so I think you should post those as part of a bigger discussion about how we want to support it and what it really means etc. johannes