MIME-Version: 1.0
In-Reply-To: <CABPxzYLFx7M=8E1pGYP7b7k-3xL9J8kYJ868BNDgkYgFOQNUQg@mail.gmail.com>
References: <1415090436-12588-1-git-send-email-emmanuel.grumbach@intel.com>
 <CABPxzYKfoO+NYi7Zs+5t6mRU+XwW5u=dKiBMsrzZ5VLO3ABDAg@mail.gmail.com>
 <B2CD83211F5FDD478D7EFFF030D107ED2AE2FDE7@hasmsx107.ger.corp.intel.com> <CABPxzYLFx7M=8E1pGYP7b7k-3xL9J8kYJ868BNDgkYgFOQNUQg@mail.gmail.com>
From: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Date: Tue, 4 Nov 2014 15:00:00 +0530
Message-ID: <CABPxzYJUYo0F5XHx6KZyBb1b9HwFkyiYfXo0Og_XtTWKLtMGxA@mail.gmail.com> (sfid-20141104_103033_848210_1BE500D6)
Subject: Re: [PATCH] mac80211: Increase uapsd max SP frames number
To: "Otcheretianski, Andrei" <andrei.otcheretianski@intel.com>
Cc: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org

On Tue, Nov 4, 2014 at 2:57 PM, Krishna Chaitanya
<chaitanya.mgit@gmail.com> wrote:
> On Tue, Nov 4, 2014 at 2:53 PM, Otcheretianski, Andrei
> <andrei.otcheretianski@intel.com> wrote:
>> The spec doesn't require unlimited to be really "unlimited" and the AP decides when to end the SP, so any value here is ok.
>> However for large traffic bursts increasing this value looks reasonable. Also looks like some certification tests expect more frames to be delivered during SP.
>> 128 is still kind of arbitrary value
>>
>>> -----Original Message-----
>>> From: Krishna Chaitanya [mailto:chaitanya.mgit@gmail.com]
>>> Sent: Tuesday, November 04, 2014 11:03
>>> To: Grumbach, Emmanuel
>>> Cc: Johannes Berg; linux-wireless; Otcheretianski, Andrei
>>> Subject: Re: [PATCH] mac80211: Increase uapsd max SP frames number
>>>
>>> On Tue, Nov 4, 2014 at 2:10 PM, Emmanuel Grumbach
>>> <emmanuel.grumbach@intel.com> wrote:
>>> > From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
>>> >
>>> > Deliver up to 128 frames during SP instead of 8 if unlimited max SP is
>>> > specified during association.
>>> >
>>> > Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
>>> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>>> > ---
>>> >  net/mac80211/sta_info.c | 2 +-
>>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >
>>> > diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index
>>> > de494df..3352741 100644
>>> > --- a/net/mac80211/sta_info.c
>>> > +++ b/net/mac80211/sta_info.c
>>> > @@ -1531,7 +1531,7 @@ void ieee80211_sta_ps_deliver_uapsd(struct
>>> sta_info *sta)
>>> >                 break;
>>> >         case 0:
>>> >                 /* XXX: what is a good value? */
>>> > -               n_frames = 8;
>>> > +               n_frames = 128;
>>> >                 break;
>>> >         }
>>> What is criteria for deciding the threshold?
>>> Any specific use case for 128?
> I understand, thanks for the explanation.

can we add the reason (certification) to the commit log?
It will be easy to understand the change.