Return-path: Received: from mail-ob0-f180.google.com ([209.85.214.180]:47803 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbaK3Twd (ORCPT ); Sun, 30 Nov 2014 14:52:33 -0500 Message-ID: <547B757F.2040900@lwfinger.net> (sfid-20141130_205259_928233_D5A73523) Date: Sun, 30 Nov 2014 13:52:31 -0600 From: Larry Finger MIME-Version: 1.0 To: nick CC: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Non Explained TODOs in halbtcoutsrc.c References: <547A581A.7040609@gmail.com> <547A9D91.9080406@lwfinger.net> <547A9F9D.8050103@gmail.com> In-Reply-To: <547A9F9D.8050103@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/29/2014 10:39 PM, nick wrote: > Larry, > Do you known who wrote that code as this I can email them for the explanations for them. > If not I assume we can remove them as the code makes logical sense unless there are > hardware or other quirks that need to be handled. :) > Cheers and Thanks for Your Time, > Nick > > On 2014-11-29 11:31 PM, Larry Finger wrote: >> On 11/29/2014 05:34 PM, nick wrote: >>> Greetings Larry, >>> After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to >>> unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this >>> file, it would be nice to hear from you on why they are needed as TODO as a comment is rather unclear for anybody >>> reading this file. >>> Nick >> >> I did not write that code. I merely make it available through the git repo, and modify it so that it will build on all kernel versions. I do not understand the TODOs any more than you do. >> >> Larry Sorry, I do not have permission to reveal the E-mail addresses of any Realtek software developers. I have added the appropriate developer as a Bcc to this E-mail. That will leave it up to that individual to respond to you. Larry