Return-path: Received: from mail-wi0-f171.google.com ([209.85.212.171]:33906 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbaKYO2T (ORCPT ); Tue, 25 Nov 2014 09:28:19 -0500 Received: by mail-wi0-f171.google.com with SMTP id bs8so9271596wib.16 for ; Tue, 25 Nov 2014 06:28:18 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v2 1/3] ath10k: add missing goto Date: Tue, 25 Nov 2014 15:16:03 +0100 Message-Id: <1416924965-28216-1-git-send-email-michal.kazior@tieto.com> (sfid-20141125_152822_726709_D70E24BF) In-Reply-To: <1416834909-7130-1-git-send-email-michal.kazior@tieto.com> References: <1416834909-7130-1-git-send-email-michal.kazior@tieto.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: This prevents warning spamming if peer creation fails during sta_state in some cases. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1245ac8..7b5a888 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3559,9 +3559,11 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, arvif->vdev_id, sta->addr, ar->num_peers); ret = ath10k_peer_create(ar, arvif->vdev_id, sta->addr); - if (ret) + if (ret) { ath10k_warn(ar, "failed to add peer %pM for vdev %d when adding a new sta: %i\n", sta->addr, arvif->vdev_id, ret); + goto exit; + } if (vif->type == NL80211_IFTYPE_STATION) { WARN_ON(arvif->is_started); -- 1.8.5.3