Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbaLOPjw (ORCPT ); Mon, 15 Dec 2014 10:39:52 -0500 From: Jes Sorensen To: Krzysztof Konopko Cc: Larry Finger , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723au: Fix sparse warnings References: <1418336609-10191-1-git-send-email-kris@konagma.com> <1418425137-13339-1-git-send-email-kris@konagma.com> Date: Mon, 15 Dec 2014 10:39:41 -0500 In-Reply-To: <1418425137-13339-1-git-send-email-kris@konagma.com> (Krzysztof Konopko's message of "Fri, 12 Dec 2014 23:58:57 +0100") Message-ID: (sfid-20141215_164012_209415_EB9DF23E) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Krzysztof Konopko writes: > Some struct fields in wifi.h are meant to be __le16 but were declared as > unsigned short. This was reported by sparse: > > rtw_wlan_util.c:538:24: warning: cast to restricted __le16 > rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 > rtw_wlan_util.c:1546:25: warning: cast to restricted __le16 > > This patch changes the types of the struct fields involved to be > little-endian which is what is received over the air and consistent with > relevant structs in include/linux/ieee80211.h. > > Signed-off-by: Krzysztof Konopko > --- > drivers/staging/rtl8723au/include/wifi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Looks OK Signed-off-by: Jes Sorensen > > diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h > index fd3da3b..266c43e 100644 > --- a/drivers/staging/rtl8723au/include/wifi.h > +++ b/drivers/staging/rtl8723au/include/wifi.h > @@ -28,7 +28,7 @@ > struct AC_param { > unsigned char ACI_AIFSN; > unsigned char CW; > - unsigned short TXOP_limit; > + __le16 TXOP_limit; > } __packed; > > struct WMM_para_element { > @@ -39,9 +39,9 @@ struct WMM_para_element { > > struct ADDBA_request { > unsigned char dialog_token; > - unsigned short BA_para_set; > - unsigned short BA_timeout_value; > - unsigned short BA_starting_seqctrl; > + __le16 BA_para_set; > + __le16 BA_timeout_value; > + __le16 BA_starting_seqctrl; > } __packed;