Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:64738 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079AbaLLW7a (ORCPT ); Fri, 12 Dec 2014 17:59:30 -0500 Received: by mail-wg0-f44.google.com with SMTP id b13so10259718wgh.3 for ; Fri, 12 Dec 2014 14:59:28 -0800 (PST) From: Krzysztof Konopko To: Larry Finger , Jes Sorensen Cc: Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kris@konagma.com Subject: [PATCH] staging: rtl8723au: Fix sparse warnings Date: Fri, 12 Dec 2014 23:58:57 +0100 Message-Id: <1418425137-13339-1-git-send-email-kris@konagma.com> (sfid-20141212_235943_315562_97B2CCDB) In-Reply-To: <1418336609-10191-1-git-send-email-kris@konagma.com> References: <1418336609-10191-1-git-send-email-kris@konagma.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Some struct fields in wifi.h are meant to be __le16 but were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 rtw_wlan_util.c:1546:25: warning: cast to restricted __le16 This patch changes the types of the struct fields involved to be little-endian which is what is received over the air and consistent with relevant structs in include/linux/ieee80211.h. Signed-off-by: Krzysztof Konopko --- drivers/staging/rtl8723au/include/wifi.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index fd3da3b..266c43e 100644 --- a/drivers/staging/rtl8723au/include/wifi.h +++ b/drivers/staging/rtl8723au/include/wifi.h @@ -28,7 +28,7 @@ struct AC_param { unsigned char ACI_AIFSN; unsigned char CW; - unsigned short TXOP_limit; + __le16 TXOP_limit; } __packed; struct WMM_para_element { @@ -39,9 +39,9 @@ struct WMM_para_element { struct ADDBA_request { unsigned char dialog_token; - unsigned short BA_para_set; - unsigned short BA_timeout_value; - unsigned short BA_starting_seqctrl; + __le16 BA_para_set; + __le16 BA_timeout_value; + __le16 BA_starting_seqctrl; } __packed; -- 2.1.3