Return-path: Received: from mail-ig0-f181.google.com ([209.85.213.181]:36325 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbaLAHNg (ORCPT ); Mon, 1 Dec 2014 02:13:36 -0500 Received: by mail-ig0-f181.google.com with SMTP id l13so8929510iga.14 for ; Sun, 30 Nov 2014 23:13:35 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 1 Dec 2014 08:13:35 +0100 Message-ID: (sfid-20141201_081339_655815_23846C70) Subject: Re: [PATCH] cfg80211: do not check for carrier during start_radar_detect From: Janusz Dziedzic To: Avinash Patil Cc: Johannes Berg , Simon Wunderlich , Amitkumar Karwar , "linux-wireless@vger.kernel.org" , Cathy Luo , "John W. Linville" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 28 November 2014 at 17:35, Avinash Patil wrote: > Yes; beats me as well. > > That's why I added original authors - Simon and Janusz. > > -Avinash > > On Nov 28, 2014 8:41 PM, Johannes Berg wrote: >> >> On Fri, 2014-11-28 at 16:58 +0530, Avinash Patil wrote: >> > Radar detection happens before starting AP; so netdev carrier may be dormant >> > at this time. Remove this check from cfg80211_start_radar_detection. >> >> Looks fine to me, but I wonder how it ever worked? >> radar detection starts before we setup AP, so woks fine Seems this patch unlock off-channel CAC (we are connected/ap started and detect radar on other channel), but seem mac80211 don't support this correctly now. So, at least we should move if (netif_carrier_ok(dev)) check to mac80211 otherwise we might change channel of the running interface (via vif_use_channel). BR Janusz >> johannes >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html