Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:36327 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbaLWGhj (ORCPT ); Tue, 23 Dec 2014 01:37:39 -0500 From: Kalle Valo To: Larry Finger Cc: Eric Biggers , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Stable Subject: Re: [PATCH for 3.19] rtlwifi: Fix error when accessing unmapped memory in skb References: <1419269826-12552-1-git-send-email-Larry.Finger@lwfinger.net> <20141222194843.GA7575@zzz> <54989E12.6050808@lwfinger.net> Date: Tue, 23 Dec 2014 08:37:31 +0200 In-Reply-To: <54989E12.6050808@lwfinger.net> (Larry Finger's message of "Mon, 22 Dec 2014 16:41:22 -0600") Message-ID: <87a92ehnx0.fsf@kamboji.qca.qualcomm.com> (sfid-20141223_073747_966645_A9C6CB1D) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger writes: > You are correct. In trying to get a small patch for stable, I missed > some important points. > > Please look at the attached patch. I think it handles the skb > allocations correctly. The critical point is that > _rtl_pci_init_one_rxdesc() cannot be allowed to fail to allocate an > skb while in the interrupt path. Now, I have already allocated the skb > before the call and bypassed this routine if the allocation fails. > After a couple of crashes, this one now works for the case when the > allocation wouldn't fail anyway. I will likely pull the allocation out > of _rtl_pci_init_one_rxdesc() in all cases for the final patch. > > @Kalle: Please drop the patch I submitted this morning with this > subject. It would not help the problem. I will resubmit after I am > sure of the proper fix. Ack. I'll wait for v2. -- Kalle Valo