Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:36324 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbaLOKba (ORCPT ); Mon, 15 Dec 2014 05:31:30 -0500 Date: Mon, 15 Dec 2014 13:31:17 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Larry Finger , Jes Sorensen , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference Message-ID: <20141215103117.GC4856@mwanda> (sfid-20141215_113143_694187_D9E3AF02) References: <1418596754-24735-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1418596754-24735-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c > index 865743e..71a6330 100644 > --- a/drivers/staging/rtl8723au/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8723au/os_dep/usb_intf.c > @@ -351,10 +351,11 @@ error_exit: > int rtw_hw_resume23a(struct rtw_adapter *padapter) That's weird. Is this function even called? regards, dan carpenter