Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:63397 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbaLQXQu (ORCPT ); Wed, 17 Dec 2014 18:16:50 -0500 Received: by mail-wg0-f45.google.com with SMTP id b13so83244wgh.32 for ; Wed, 17 Dec 2014 15:16:49 -0800 (PST) Message-ID: <54920EDC.4090007@gmail.com> (sfid-20141218_001654_052476_4EDF60CE) Date: Wed, 17 Dec 2014 23:16:44 +0000 From: Malcolm Priestley MIME-Version: 1.0 To: gregkh@linuxfoundation.org CC: linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/6] staging: vt6655: set_channel replace parameter with ieee80211_channel References: <1417731167-3231-1-git-send-email-tvboxspy@gmail.com> In-Reply-To: <1417731167-3231-1-git-send-email-tvboxspy@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/12/14 22:12, Malcolm Priestley wrote: > replacing uConnectionChannel for hw_value as set in vnt_init_bands. > > This allows other signaling of ieee80211_channel to move deeper into > driver. > > Signed-off-by: Malcolm Priestley > --- Hi greg Can you drop this patch series altogether. I will repost these later after some needed bug fixes for 3.19 Malcolm > drivers/staging/vt6655/channel.c | 12 ++++++------ > drivers/staging/vt6655/channel.h | 2 +- > drivers/staging/vt6655/device_main.c | 2 +- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c > index c8f739d..6514869 100644 > --- a/drivers/staging/vt6655/channel.c > +++ b/drivers/staging/vt6655/channel.c > @@ -174,12 +174,12 @@ void vnt_init_bands(struct vnt_private *priv) > * Return Value: true if succeeded; false if failed. > * > */ > -bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel) > +bool set_channel(void *pDeviceHandler, struct ieee80211_channel *ch) > { > struct vnt_private *pDevice = pDeviceHandler; > bool bResult = true; > > - if (pDevice->byCurrentCh == uConnectionChannel) > + if (pDevice->byCurrentCh == ch->hw_value) > return bResult; > > /* clear NAV */ > @@ -189,15 +189,15 @@ bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel) > > if (pDevice->byRFType == RF_AIROHA7230) > RFbAL7230SelectChannelPostProcess(pDevice, pDevice->byCurrentCh, > - (unsigned char)uConnectionChannel); > + (unsigned char)ch->hw_value); > > - pDevice->byCurrentCh = (unsigned char)uConnectionChannel; > + pDevice->byCurrentCh = (unsigned char)ch->hw_value; > bResult &= RFbSelectChannel(pDevice, pDevice->byRFType, > - (unsigned char)uConnectionChannel); > + (unsigned char)ch->hw_value); > > /* Init Synthesizer Table */ > if (pDevice->bEnablePSMode) > - RFvWriteWakeProgSyn(pDevice, pDevice->byRFType, uConnectionChannel); > + RFvWriteWakeProgSyn(pDevice, pDevice->byRFType, ch->hw_value); > > BBvSoftwareReset(pDevice); > > diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h > index 4f4264e..e2be6fc 100644 > --- a/drivers/staging/vt6655/channel.h > +++ b/drivers/staging/vt6655/channel.h > @@ -27,6 +27,6 @@ > > void vnt_init_bands(struct vnt_private *); > > -bool set_channel(void *pDeviceHandler, unsigned int uConnectionChannel); > +bool set_channel(void *pDeviceHandler, struct ieee80211_channel *); > > #endif /* _CHANNEL_H_ */ > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c > index 83e4162..b50c4f2 100644 > --- a/drivers/staging/vt6655/device_main.c > +++ b/drivers/staging/vt6655/device_main.c > @@ -1415,7 +1415,7 @@ static int vnt_config(struct ieee80211_hw *hw, u32 changed) > > if ((changed & IEEE80211_CONF_CHANGE_CHANNEL) || > (conf->flags & IEEE80211_CONF_OFFCHANNEL)) { > - set_channel(priv, conf->chandef.chan->hw_value); > + set_channel(priv, conf->chandef.chan); > > if (conf->chandef.chan->band == IEEE80211_BAND_5GHZ) > bb_type = BB_TYPE_11A; >