Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:33375 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967664AbaLLNYW (ORCPT ); Fri, 12 Dec 2014 08:24:22 -0500 Message-ID: <1418390652.2470.47.camel@sipsolutions.net> (sfid-20141212_142439_414833_EF280C42) Subject: Re: [PATCH] staging: rtl8723au: Fix sparse warnings From: Johannes Berg To: Krzysztof Konopko Cc: Larry Finger , Jes Sorensen , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 12 Dec 2014 14:24:12 +0100 In-Reply-To: <548AD2F1.3080200@konagma.com> (sfid-20141212_123521_918435_E1E26083) References: <1418336609-10191-1-git-send-email-kris@konagma.com> <548A2E7A.4010303@lwfinger.net> <548AD2F1.3080200@konagma.com> (sfid-20141212_123521_918435_E1E26083) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2014-12-12 at 12:35 +0100, Krzysztof Konopko wrote: > I'm _far_ from being a wireless expert but doesn't data coming out of > the wire/air have the endianess defined explicitly? And both `AC_param` > and `ADDBA_request` come out of air? In general, data in 802.11 frames is little endian. Both of these would appear to correspond to data received/sent over the air, so __le would make sense. johannes