Return-path: Received: from imap.thunk.org ([74.207.234.97]:48015 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbaLaVoe (ORCPT ); Wed, 31 Dec 2014 16:44:34 -0500 Date: Wed, 31 Dec 2014 16:44:21 -0500 From: Theodore Ts'o To: Arend van Spriel Cc: Jiri Kosina , "Grumbach, Emmanuel" , Linus Torvalds , Borislav Petkov , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "egrumbach@gmail.com" , "peter@hurleysoftware.com" , "ilw@linux.intel.com" , "Berg, Johannes" , Larry Finger Subject: Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable" Message-ID: <20141231214421.GA29273@thunk.org> (sfid-20141231_224459_045012_F9F7AF5F) References: <54A328C2.5080606@lwfinger.net> <54A3D955.6020809@broadcom.com> <0BA3FCBA62E2DC44AF3030971E174FB31B5DD72E@hasmsx107.ger.corp.intel.com> <54A3E1F1.7030807@broadcom.com> <54A41000.3040306@broadcom.com> <20141231173113.GA443@thunk.org> <54A45D4D.7070302@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <54A45D4D.7070302@broadcom.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Dec 31, 2014 at 09:32:13PM +0100, Arend van Spriel wrote: > > Agree. I can't even recall using "ip" ever. iw help system does provide > command specific help. The phy keyword is both a command and a selector key, > which I realize is confusing to the user, eg. 'iw help info' does provide > help for the 'info' subcommand. Yeah, the confusing part is that "ip" tends to use "verb object" scheme, which is consistent with the Cisco IOS command set it was trying to emulate. So for ip, you do something like ip link info eth0 Where as for "iw" it's almost exactly backwards, i.e.: iw wlan0 info It's actually rather unfortunate that there is no consistency between many of these tools, for example: ethtool --show-features eth0 If we were going to create a new interface, wouldn't be nice if we could have some kind of consistency? Sigh; oh well, water under the bridge at this point. > Thanks. If there are still drivers, upstream or out-of-tree, providing only > WEXT API this will not work unless iwconfig/iwlist can distinguish those > from cfg80211-based drivers (which is possible) and fallback to WEXT ioctl > syscalls. Just not sure if it is worth the effort. As you stated below, it > does not seem "evil" to retain WEXT if that is providing users what they > need. Is it really that much effort? Unless there is some license incompatibility nonsense (i.e., GPLv2 vs GPLv3), the code's already there in the wireless-tools source. It would just be a matter of trying the new ioctls first, and then falling back to the WEXT ones if needed, right? Cheers, - Ted