Return-path: Received: from mail-wi0-f171.google.com ([209.85.212.171]:43558 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbbABMW4 convert rfc822-to-8bit (ORCPT ); Fri, 2 Jan 2015 07:22:56 -0500 Received: by mail-wi0-f171.google.com with SMTP id bs8so27666760wib.10 for ; Fri, 02 Jan 2015 04:22:54 -0800 (PST) MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <1420127170-28421-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Fri, 2 Jan 2015 13:14:47 +0100 Message-ID: (sfid-20150102_133201_067727_AEC85B74) Subject: Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function From: Sedat Dilek To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rickard Strandqvist , Larry Finger , Stefano Brivio , Network Development , "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: > On 2 January 2015 at 13:05, Rafał Miłecki wrote: >> On 1 January 2015 at 16:46, Rickard Strandqvist >> wrote: >>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >>> >>> This was partially found by using a static code analysis program called cppcheck. >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> is not handled by b43legacy. Should be safe to drop this code (we >> won't likely need it). >> >> Ack > > For future, we prefix patches with just a driver name. So this could > be simply called > b43legacy: radio.c: Remove unused function > Alternatively... "b43legacy: Remove unused function in radio.c" BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff? - Sedat - [1] https://lkml.org/lkml/2015/1/2/51