Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:41841 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbbAaPJh (ORCPT ); Sat, 31 Jan 2015 10:09:37 -0500 Received: by mail-wi0-f170.google.com with SMTP id bs8so8018269wib.1 for ; Sat, 31 Jan 2015 07:09:36 -0800 (PST) From: Rickard Strandqvist To: Larry Finger , Jes Sorensen Cc: Rickard Strandqvist , Greg Kroah-Hartman , Joe Perches , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used Date: Sat, 31 Jan 2015 16:12:57 +0100 Message-Id: <1422717177-5865-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (sfid-20150131_160940_415339_1A06B2FF) Sender: linux-wireless-owner@vger.kernel.org List-ID: Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_ops_linux.c b/drivers/staging/rtl8723au/hal/usb_ops_linux.c index a6d16ad..4ae0a8a 100644 --- a/drivers/staging/rtl8723au/hal/usb_ops_linux.c +++ b/drivers/staging/rtl8723au/hal/usb_ops_linux.c @@ -26,11 +26,10 @@ u8 rtl8723au_read8(struct rtw_adapter *padapter, u16 addr) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); struct usb_device *udev = pdvobjpriv->pusbdev; - int len; u8 data; mutex_lock(&pdvobjpriv->usb_vendor_req_mutex); - len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), REALTEK_USB_VENQT_CMD_REQ, REALTEK_USB_VENQT_READ, addr, 0, &pdvobjpriv->usb_buf.val8, sizeof(data), RTW_USB_CONTROL_MSG_TIMEOUT); @@ -45,11 +44,10 @@ u16 rtl8723au_read16(struct rtw_adapter *padapter, u16 addr) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); struct usb_device *udev = pdvobjpriv->pusbdev; - int len; u16 data; mutex_lock(&pdvobjpriv->usb_vendor_req_mutex); - len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), REALTEK_USB_VENQT_CMD_REQ, REALTEK_USB_VENQT_READ, addr, 0, &pdvobjpriv->usb_buf.val16, sizeof(data), RTW_USB_CONTROL_MSG_TIMEOUT); @@ -64,11 +62,10 @@ u32 rtl8723au_read32(struct rtw_adapter *padapter, u16 addr) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); struct usb_device *udev = pdvobjpriv->pusbdev; - int len; u32 data; mutex_lock(&pdvobjpriv->usb_vendor_req_mutex); - len = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), REALTEK_USB_VENQT_CMD_REQ, REALTEK_USB_VENQT_READ, addr, 0, &pdvobjpriv->usb_buf.val32, sizeof(data), RTW_USB_CONTROL_MSG_TIMEOUT); -- 1.7.10.4