Return-path: Received: from mail-ie0-f195.google.com ([209.85.223.195]:48514 "EHLO mail-ie0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbbACOpg convert rfc822-to-8bit (ORCPT ); Sat, 3 Jan 2015 09:45:36 -0500 Received: by mail-ie0-f195.google.com with SMTP id rd18so4952086iec.6 for ; Sat, 03 Jan 2015 06:45:35 -0800 (PST) Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com. [209.85.223.181]) by mx.google.com with ESMTPSA id e3sm1007821igg.16.2015.01.03.06.45.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 03 Jan 2015 06:45:34 -0800 (PST) Received: by mail-ie0-f181.google.com with SMTP id rl12so15870121iec.12 for ; Sat, 03 Jan 2015 06:45:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1420127170-28421-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Sat, 3 Jan 2015 15:45:33 +0100 Message-ID: (sfid-20150103_154611_445762_429897DD) Subject: Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function From: Rickard Strandqvist To: Sedat Dilek Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Larry Finger , Stefano Brivio , Network Development , "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2015-01-03 14:19 GMT+01:00 Sedat Dilek : > > On Sat, Jan 3, 2015 at 1:28 PM, Rickard Strandqvist > wrote: > > 2015-01-02 22:34 GMT+01:00 Rafał Miłecki : > >> > >> On 2 January 2015 at 18:46, Rickard Strandqvist > >> wrote: > >> > 2015-01-02 13:14 GMT+01:00 Sedat Dilek : > >> >> > >> >> On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki wrote: > >> >> > On 2 January 2015 at 13:05, Rafał Miłecki wrote: > >> >> >> On 1 January 2015 at 16:46, Rickard Strandqvist > >> >> >> wrote: > >> >> >>> Remove the function b43legacy_radio_set_tx_iq() that is not used > >> >> >>> anywhere. > >> >> >>> > >> >> >>> This was partially found by using a static code analysis program > >> >> >>> called cppcheck. > >> >> >> > >> >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which > >> >> >> is not handled by b43legacy. Should be safe to drop this code (we > >> >> >> won't likely need it). > >> >> >> > >> >> >> Ack > >> >> > > >> >> > For future, we prefix patches with just a driver name. So this could > >> >> > be simply called > >> >> > b43legacy: radio.c: Remove unused function > >> >> > > >> >> > >> >> Alternatively... > >> >> > >> >> "b43legacy: Remove unused function in radio.c" > >> >> > >> >> BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck > >> >> to get such stuff? > >> >> > >> >> - Sedat - > >> >> > >> >> [1] https://lkml.org/lkml/2015/1/2/51 > >> > > >> > > >> > > >> > Hi Rafal and Sedat > >> > > >> > Rafal do you mean I should remove the entire b43legacy part? > >> > >> 1) I gave you Ack for the changes > >> 2) You could drop "net: wireless: " or better use something Sedat proposed > >> > >> -- > >> Rafał > > > > > > > > Hi > > > > Nice, yes I miss the Ack :) > > > > I just got one more complaining about my subject-line in "net: wireless: " > > I use some sed call for this, so it's easy to fix. I will now remove that > > part hereinafter. > > I check in Documentation/ but did not find any clear info for this. > > > > The easiest way to make (sub)maintainers happy is to check the git-log... > > $ git log --oneline /path/to/file > > ...and look how other contributors labeled their patches. > > [1] is the 1st address to look at on how to submit patches to Linux-kernel. > To promote the good work of Greg, see [2,3] for a video and tutorial > on that topic, too. > > - Sedat - > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches > [2] https://www.youtube.com/watch?v=XXix80GCvpo > [3] https://github.com/gregkh/kernel-tutorial Hi Sedat Thanks for the tip :) To bad with the audio in the video thow. Have read SubmittingPatches before. But I have now added a line in my script that does a: git log -10 --oneline So I can at least see the other subjekt lines, and make adjustments if necessary. Kind regards Rickard Strandqvist