Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:45908 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbbALOG4 (ORCPT ); Mon, 12 Jan 2015 09:06:56 -0500 Received: by mail-la0-f46.google.com with SMTP id q1so24284000lam.5 for ; Mon, 12 Jan 2015 06:06:54 -0800 (PST) Message-ID: <54B3D4FC.1090806@cogentembedded.com> (sfid-20150112_150725_139287_DA7323D7) Date: Mon, 12 Jan 2015 17:06:52 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: "Fu, Zhonghui" , brudley@broadcom.com, "arend@broadcom.com >> Arend van Spriel" , Franky Lin , meuleman@broadcom.com, kvalo@codeaurora.org, linville@tuxdriver.com, pieterpg@broadcom.com, hdegoede@redhat.com, wens@csie.org, linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation References: <54B36C88.3030609@linux.intel.com> In-Reply-To: <54B36C88.3030609@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 1/12/2015 9:41 AM, Fu, Zhonghui wrote: > From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 > From: Zhonghui Fu > Date: Mon, 12 Jan 2015 14:25:46 +0800 > Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation The lines above are not needed. > WiFi chip has 2 SDIO functions, and PM core will trigger > twice suspend/resume operations for one WiFi chip to do > the same things. This patch avoid this case. > Acked-by: Arend van Spriel > Acked-by: Sergei Shtylyov > Signed-off-by: Zhonghui Fu > --- > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 21 +++++++++++++++++---- > 1 files changed, 17 insertions(+), 4 deletions(-) > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > index 9880dae..8f71485 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > @@ -1070,7 +1070,7 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func, > */ > if ((sdio_get_host_pm_caps(sdiodev->func[1]) & MMC_PM_KEEP_POWER) && > ((sdio_get_host_pm_caps(sdiodev->func[1]) & MMC_PM_WAKE_SDIO_IRQ) || > - (sdiodev->pdata && sdiodev->pdata->oob_irq_supported))) > + (sdiodev->pdata->oob_irq_supported))) Inner parens not needed on this line. [...] WBR, Sergei