Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:54208 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbbAOLnA (ORCPT ); Thu, 15 Jan 2015 06:43:00 -0500 From: Kalle Valo To: Larry Finger Cc: linux-wireless@vger.kernel.org, Troy Tan , netdev@vger.kernel.org Subject: Re: [PATCH for 3.19 3/3] rtlwifi: rtl8192ee: Fix several bugs References: <1421257036-5382-1-git-send-email-Larry.Finger@lwfinger.net> <1421257036-5382-4-git-send-email-Larry.Finger@lwfinger.net> Date: Thu, 15 Jan 2015 13:42:52 +0200 In-Reply-To: <1421257036-5382-4-git-send-email-Larry.Finger@lwfinger.net> (Larry Finger's message of "Wed, 14 Jan 2015 11:37:16 -0600") Message-ID: <87bnm0xoar.fsf@kamboji.qca.qualcomm.com> (sfid-20150115_124308_600605_5BB11301) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger writes: > From: Troy Tan > > The following bugs are fixed in this driver: > 1. Problems parsing C2H CMD > 2. An ad-hoc connection can cause a TX freeze. > 3. There are additional conditions that cause a TX freeze. > 4. The previous code failed to handle situations where an RX > descriptor was unavailable. > > Signed-off-by: Troy Tan > Signed-off-by: Larry Finger Is this really so important that it should go to 3.19? A patch titled "Fix several bugs" immediately makes me cautious and then I look at the patch itself I see rewriting functions instead of simple bug fixes. From a quick look this looks more -next material than 3.19. -- Kalle Valo