Return-path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:38753 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbbACOvc (ORCPT ); Sat, 3 Jan 2015 09:51:32 -0500 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <1420127170-28421-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Sat, 3 Jan 2015 15:51:30 +0100 Message-ID: (sfid-20150103_155136_369747_A90B01F0) Subject: Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function From: Sedat Dilek To: Rickard Strandqvist Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Larry Finger , Stefano Brivio , Network Development , "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jan 3, 2015 at 3:45 PM, Rickard Strandqvist wrote: [ ... ] >> > I just got one more complaining about my subject-line in "net: wireless: " >> > I use some sed call for this, so it's easy to fix. I will now remove that >> > part hereinafter. >> > I check in Documentation/ but did not find any clear info for this. >> > >> >> The easiest way to make (sub)maintainers happy is to check the git-log... >> >> $ git log --oneline /path/to/file >> >> ...and look how other contributors labeled their patches. >> >> [1] is the 1st address to look at on how to submit patches to Linux-kernel. >> To promote the good work of Greg, see [2,3] for a video and tutorial >> on that topic, too. >> >> - Sedat - >> >> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches >> [2] https://www.youtube.com/watch?v=XXix80GCvpo >> [3] https://github.com/gregkh/kernel-tutorial > > > > Hi Sedat > > Thanks for the tip :) > > To bad with the audio in the video thow. Have read SubmittingPatches before. > AFAICS there is another (earlier) video "Write and Submit your first Linux kernel Patch" from FOSDEM 2010. For German readers I can recommend the book from [2] (no I get no money for promotion). - Sedat - [1] https://www.youtube.com/watch?v=LLBrBBImJt4 [2] http://www.opensourcepress.de/de/produkte/Git/33227/978-3-95539-119-5- > > But I have now added a line in my script that does a: > > git log -10 --oneline > > So I can at least see the other subjekt lines, and make adjustments if > necessary. > > > > Kind regards > Rickard Strandqvist