Return-path: Received: from mail-ie0-f176.google.com ([209.85.223.176]:55139 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbbABMF2 convert rfc822-to-8bit (ORCPT ); Fri, 2 Jan 2015 07:05:28 -0500 MIME-Version: 1.0 In-Reply-To: <1420127170-28421-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1420127170-28421-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Fri, 2 Jan 2015 13:05:26 +0100 Message-ID: (sfid-20150102_130540_975336_B9B1B882) Subject: Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Rickard Strandqvist Cc: Larry Finger , Stefano Brivio , Network Development , "linux-wireless@vger.kernel.org" , Linux Kernel Mailing List , b43-dev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 1 January 2015 at 16:46, Rickard Strandqvist wrote: > Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware (with 0x2060 radio id) which is not handled by b43legacy. Should be safe to drop this code (we won't likely need it). Ack -- Rafał