Return-path: Received: from mail-oi0-f42.google.com ([209.85.218.42]:40524 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbbADGVn (ORCPT ); Sun, 4 Jan 2015 01:21:43 -0500 Message-ID: <54A8DBF4.4050202@lwfinger.net> (sfid-20150104_072224_120372_218FAD52) Date: Sun, 04 Jan 2015 00:21:40 -0600 From: Larry Finger MIME-Version: 1.0 To: Rickard Strandqvist , Brett Rudley , Arend van Spriel CC: Hante Meuleman , Kalle Valo , Fabian Frederick , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] brcm80211: brcmsmac: dma: Remove some unused functions References: <1420332469-5907-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1420332469-5907-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/03/2015 06:47 PM, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > dma_txflush() dma_txsuspended() > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/net/wireless/brcm80211/brcmsmac/dma.c | 19 ------------------- > drivers/net/wireless/brcm80211/brcmsmac/dma.h | 2 -- > 2 files changed, 21 deletions(-) Just because file dma.c is involved, it does not need to be, nor should it be in the subject line. You could specify the driver names in the file tree after wireless. In this instance, one possible subject would be "brcm80211: brcmsmac: Remove some unused functions". On the other hand, if you look at "git log" to see past patches, the driver maintainers even leave off the brcm80211 part, thus to match them, the subject should be "brcmsmac: Remove some unused functions". As was suggested earlier, you need to look at the precedents. Keeping a uniform method of patch naming helps when looking for patches in the git log. Larry