Return-path: Received: from mail-wi0-f178.google.com ([209.85.212.178]:48436 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbbAGNtM (ORCPT ); Wed, 7 Jan 2015 08:49:12 -0500 Received: by mail-wi0-f178.google.com with SMTP id em10so1647730wid.5 for ; Wed, 07 Jan 2015 05:49:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1420638389.3407.13.camel@sipsolutions.net> References: <1419847199-25493-1-git-send-email-arik@wizery.com> <1420541514.1966.16.camel@sipsolutions.net> <1420637871.3407.10.camel@sipsolutions.net> <1420638389.3407.13.camel@sipsolutions.net> From: Arik Nemtsov Date: Wed, 7 Jan 2015 15:48:56 +0200 Message-ID: (sfid-20150107_144916_647491_C51944D1) Subject: Re: [PATCH] cfg80211: fix deadlock during reg chan check To: Johannes Berg Cc: "linux-wireless@vger.kernel.org" , "Luis R. Rodriguez" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: > >> > >> >> > Also, the only reason this can happen anyway is when you call "can >> >> > beacon" for a station interface - which seems nonsensical. Given that >> >> >> >> This is not true. This happens with current code for a p2p-go >> >> interface during channel validity checks in reg.c. >> > >> > Not sure I see this? The only thing doing wdev locking is >> > cfg80211_go_permissive_chan(), no? And that only for station interfaces. >> >> cfg80211_go_permissive_chan is called from cfg80211_reg_can_beacon, >> currently only for GO interfaces, but for STA also in the future >> (hopefully). >> The latter is called during channel validity checks for GO. > > Ok. > > Should I just apply the patch as it is then? It fixes a real existing deadlock, so I think so, yea. Arik