Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:53302 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754472AbbAFSI4 (ORCPT ); Tue, 6 Jan 2015 13:08:56 -0500 Message-ID: <54AC2497.3050703@lwfinger.net> (sfid-20150106_190930_327701_06C3D99D) Date: Tue, 06 Jan 2015 12:08:23 -0600 From: Larry Finger MIME-Version: 1.0 To: Rickard Strandqvist CC: Kalle Valo , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] b43legacy: Remove unused function References: <1420567175-17323-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1420567175-17323-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/06/2015 11:59 AM, Rickard Strandqvist wrote: > Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/net/wireless/b43legacy/radio.c | 19 ------------------- > drivers/net/wireless/b43legacy/radio.h | 1 - > 2 files changed, 20 deletions(-) Acked-by: Larry Finger Larry > > diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c > index 8961776..9501420 100644 > --- a/drivers/net/wireless/b43legacy/radio.c > +++ b/drivers/net/wireless/b43legacy/radio.c > @@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency) > return value; > } > > -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev) > -{ > - static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 }; > - static const u8 data_low[5] = { 0x00, 0x01, 0x05, 0x06, 0x0A }; > - u16 tmp = b43legacy_radio_read16(dev, 0x001E); > - int i; > - int j; > - > - for (i = 0; i < 5; i++) { > - for (j = 0; j < 5; j++) { > - if (tmp == (data_high[i] | data_low[j])) { > - b43legacy_phy_write(dev, 0x0069, (i - j) << 8 | > - 0x00C0); > - return; > - } > - } > - } > -} > - > int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev, > u8 channel, > int synthetic_pu_workaround) > diff --git a/drivers/net/wireless/b43legacy/radio.h b/drivers/net/wireless/b43legacy/radio.h > index bccb3d7..dd2976d 100644 > --- a/drivers/net/wireless/b43legacy/radio.h > +++ b/drivers/net/wireless/b43legacy/radio.h > @@ -92,7 +92,6 @@ void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val); > void b43legacy_nrssi_hw_update(struct b43legacy_wldev *dev, u16 val); > void b43legacy_nrssi_mem_update(struct b43legacy_wldev *dev); > > -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev); > u16 b43legacy_radio_calibrationvalue(struct b43legacy_wldev *dev); > > #endif /* B43legacy_RADIO_H_ */ >