Return-path: Received: from mail-ob0-f171.google.com ([209.85.214.171]:35091 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753199AbbAOUKU (ORCPT ); Thu, 15 Jan 2015 15:10:20 -0500 Message-ID: <54B81EAA.9040706@lwfinger.net> (sfid-20150115_211030_952221_764FEEC9) Date: Thu, 15 Jan 2015 14:10:18 -0600 From: Larry Finger MIME-Version: 1.0 To: Kalle Valo , =?UTF-8?B?6LCt5p2t5rOi?= CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors References: <1421257036-5382-1-git-send-email-Larry.Finger@lwfinger.net> <1421257036-5382-3-git-send-email-Larry.Finger@lwfinger.net> <877fwoxo7g.fsf@kamboji.qca.qualcomm.com> <87y4p4w8wb.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87y4p4w8wb.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/15/2015 06:00 AM, Kalle Valo wrote: > Hi Troy, > > please avoid top-posting. > > 谭杭波 writes: > >> You can find get_available_desc here: >> >> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/ >> pci.c >> index e25faac..a62170e 100644 >> --- a/drivers/net/wireless/rtlwifi/pci.c >> +++ b/drivers/net/wireless/rtlwifi/pci.c >> @@ -578,6 +578,13 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int >> prio) >> else >> entry = (u8 *)(&ring->desc[ring->idx]); >> >> + if (rtlpriv->cfg->ops->get_available_desc && >> + rtlpriv->cfg->ops->get_available_desc(hw, prio) <= 1) { >> + RT_TRACE(rtlpriv, (COMP_INTR | COMP_SEND), DBG_DMESG, >> + "no available desc!\n"); >> + return; >> + } > > I don't see rtlpriv->cfg->ops->get_available_desc set here, only being > called? Kalle, Troy and I will try to prepare a patch that only fixes the bugs, and we will submit the cleanup for -next. Sorry for the noise, Larry