Message-ID: <54B8323D.6020304@gmail.com> (sfid-20150115_223414_584751_4815E9E7)
Date: Thu, 15 Jan 2015 22:33:49 +0100
From: "christophe.ricard" <christophe.ricard@gmail.com>
MIME-Version: 1.0
To: Anda-Maria Nicolae <anda-maria.nicolae@intel.com>,
	lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
	sameo@linux.intel.com, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] NFC: st21nfcb: Avoid use of skb after free
References: <1421317857-1713-1-git-send-email-anda-maria.nicolae@intel.com>
In-Reply-To: <1421317857-1713-1-git-send-email-anda-maria.nicolae@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

Hi Anda-Maria,

I agree with your fix. I have built and tested it successfully.
I will include it in a new patch series with a:
Acked-by: Christophe Ricard <christophe-h.ricard@st.com>

Thanks a lot.
Christophe
On 15/01/2015 11:30, Anda-Maria Nicolae wrote:
> Do not insert in send queue the skb that contains unknown Packet Control Byte
>
> Signed-off-by: Anda-Maria Nicolae <anda-maria.nicolae@intel.com>
> ---
> Only compile tested, please have a look
>
>   drivers/nfc/st21nfcb/ndlc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/st21nfcb/ndlc.c b/drivers/nfc/st21nfcb/ndlc.c
> index bac50e8..72659a3 100644
> --- a/drivers/nfc/st21nfcb/ndlc.c
> +++ b/drivers/nfc/st21nfcb/ndlc.c
> @@ -138,7 +138,7 @@ static void llt_ndlc_requeue_data_pending(struct llt_ndlc *ndlc)
>   		default:
>   			pr_err("UNKNOWN Packet Control Byte=%d\n", pcb);
>   			kfree_skb(skb);
> -			break;
> +			continue;
>   		}
>   		skb_queue_head(&ndlc->send_q, skb);
>   	}