From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy
References: <1417963040-9014-1-git-send-email-kernel@esmil.dk>
	<20150117215040.GA16839@kroah.com>
Date: Sun, 18 Jan 2015 10:24:28 -0500
In-Reply-To: <20150117215040.GA16839@kroah.com> (Greg Kroah-Hartman's message
	of "Sat, 17 Jan 2015 13:50:40 -0800")
Message-ID: <wrfjzj9gt8lv.fsf@redhat.com> (sfid-20150118_162453_278500_A87E658F)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Sun, Dec 07, 2014 at 03:37:20PM +0100, Emil Renner Berthing wrote:
>> This also fixes a sparse warning.
>
> What sparse warning?  What's wrong with the original code?  Unless Jes
> resends this to me, I don't see the need to apply it, sorry.

I agree, I cannot see what this is fixing, it does however add an ugly
cast.

If you want to change the paramters passed to FillH2CCmd() then change
the prototype and create something like struct h2c_cmd_arg{} and apply
that across the board.

NACK

Jes