Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:55091 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbbAOMA7 convert rfc822-to-8bit (ORCPT ); Thu, 15 Jan 2015 07:00:59 -0500 From: Kalle Valo To: =?utf-8?B?6LCt5p2t5rOi?= Cc: "larry.finger" , "linux-wireless\@vger.kernel.org" , "netdev\@vger.kernel.org" Subject: Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors References: <1421257036-5382-1-git-send-email-Larry.Finger@lwfinger.net> <1421257036-5382-3-git-send-email-Larry.Finger@lwfinger.net> <877fwoxo7g.fsf@kamboji.qca.qualcomm.com> Date: Thu, 15 Jan 2015 14:00:52 +0200 In-Reply-To: (=?utf-8?B?IuiwreadreazoiIncw==?= message of "Thu, 15 Jan 2015 11:46:55 +0000") Message-ID: <87y4p4w8wb.fsf@kamboji.qca.qualcomm.com> (sfid-20150115_130109_726659_117107B7) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Troy, please avoid top-posting. 谭杭波 writes: > You can find get_available_desc here: > > diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/ > pci.c > index e25faac..a62170e 100644 > --- a/drivers/net/wireless/rtlwifi/pci.c > +++ b/drivers/net/wireless/rtlwifi/pci.c > @@ -578,6 +578,13 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int > prio) > else > entry = (u8 *)(&ring->desc[ring->idx]); > > + if (rtlpriv->cfg->ops->get_available_desc && > + rtlpriv->cfg->ops->get_available_desc(hw, prio) <= 1) { > + RT_TRACE(rtlpriv, (COMP_INTR | COMP_SEND), DBG_DMESG, > + "no available desc!\n"); > + return; > + } I don't see rtlpriv->cfg->ops->get_available_desc set here, only being called? -- Kalle Valo