Return-path: Received: from mail-ob0-f179.google.com ([209.85.214.179]:59085 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbbAMRTl (ORCPT ); Tue, 13 Jan 2015 12:19:41 -0500 Message-ID: <54B553AA.50505@lwfinger.net> (sfid-20150113_182003_359601_B150A52F) Date: Tue, 13 Jan 2015 11:19:38 -0600 From: Larry Finger MIME-Version: 1.0 To: Colin King , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtlwifi/rtl8192de: remove redundant else if check References: <1421158054-22566-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1421158054-22566-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/13/2015 08:07 AM, Colin King wrote: > From: Colin Ian King > > The else if check condition checks for the opposite of the > if check, hence the else if check is redundant and can be > replaced with a simple else: > > if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { > .. > } else if (rtlpriv->rtlhal.macphymode != SINGLEMAC_SINGLEPHY) { > .. > } > > replaced with: > > if (rtlpriv->rtlhal.macphymode == SINGLEMAC_SINGLEPHY) { > .. > } else { > .. > } > > Signed-off-by: Colin Ian King Acked-by: Larry Finger Thanks, Larry > --- > drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > index 280c3da..01bcc2d 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c > @@ -546,7 +546,7 @@ static bool _rtl92de_llt_table_init(struct ieee80211_hw *hw) > txpktbuf_bndy = 246; > value8 = 0; > value32 = 0x80bf0d29; > - } else if (rtlpriv->rtlhal.macphymode != SINGLEMAC_SINGLEPHY) { > + } else { > maxPage = 127; > txpktbuf_bndy = 123; > value8 = 0; >