Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:53427 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbbAEJym (ORCPT ); Mon, 5 Jan 2015 04:54:42 -0500 Message-ID: <1420451671.9459.1.camel@sipsolutions.net> (sfid-20150105_105500_749061_B2F71187) Subject: Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest From: Johannes Berg To: Giel van Schijndel Cc: linux-kernel@vger.kernel.org, Kalle Valo , Eliad Peller , "John W. Linville" , Arik Nemtsov , "open list:TI WILINK WIRELES..." , "open list:NETWORKING DRIVERS" Date: Mon, 05 Jan 2015 10:54:31 +0100 In-Reply-To: <1420394427-19509-2-git-send-email-me@mortis.eu> (sfid-20150104_201205_499836_1F2052B2) References: <1420394427-19509-1-git-send-email-me@mortis.eu> <1420394427-19509-2-git-send-email-me@mortis.eu> (sfid-20150104_201205_499836_1F2052B2) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, 2015-01-04 at 19:00 +0100, Giel van Schijndel wrote: > --- > drivers/net/wireless/ti/wlcore/acx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c > index beb354c..93a2fa8 100644 > --- a/drivers/net/wireless/ti/wlcore/acx.c > +++ b/drivers/net/wireless/ti/wlcore/acx.c > @@ -1725,7 +1725,7 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl) > acx->decrease_delta = conf->decrease_delta; > acx->quiet_time = conf->quiet_time; > acx->increase_time = conf->increase_time; > - acx->window_size = acx->window_size; > + acx->window_size = conf->window_size; It would be far better to fix the bug *first*, that way the bugfix can be cherry-picked/applied to trees that don't have the alignment. (And anyway I question the value of the alignment - if you really want to make this bug disappear you could perhaps use a macro) johannes