Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:36151 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbbAGNmu (ORCPT ); Wed, 7 Jan 2015 08:42:50 -0500 Message-ID: <1420638161.3407.12.camel@sipsolutions.net> (sfid-20150107_144254_022718_FE5738E1) Subject: Re: [PATCH 2/2] cfg80211: avoid reg-hints in self-managed only systems From: Johannes Berg To: Arik Nemtsov Cc: "linux-wireless@vger.kernel.org" , "Luis R. Rodriguez" Date: Wed, 07 Jan 2015 14:42:41 +0100 In-Reply-To: (sfid-20150107_143849_596007_E296D7AF) References: <1420112563-3981-1-git-send-email-arik@wizery.com> <1420112563-3981-2-git-send-email-arik@wizery.com> <1420541766.1966.18.camel@sipsolutions.net> <1420552744.1966.31.camel@sipsolutions.net> (sfid-20150107_143849_596007_E296D7AF) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2015-01-07 at 15:38 +0200, Arik Nemtsov wrote: > On Tue, Jan 6, 2015 at 4:04 PM, Arik Nemtsov wrote: > > On Tue, Jan 6, 2015 at 3:59 PM, Johannes Berg wrote: > >> On Tue, 2015-01-06 at 11:56 +0100, Johannes Berg wrote: > >>> On Thu, 2015-01-01 at 13:42 +0200, Arik Nemtsov wrote: > >>> > When a system contains only self-managed regulatory devices all hints > >>> > from the regulatory core are ignored. Stop hint processing early in this > >>> > case. These systems usually don't have CRDA deployed, which results in > >>> > endless (irrelevent) logs of the form: > >>> > cfg80211: Calling CRDA to update world regulatory domain > >>> > >>> Applied. > >> > >> I take that back - dropped again. This was causing spurious messages in > >> the hwsim test run VM, saying something like "couldn't set reg domain: > >> -7". Maybe at that point not a single wiphy existed? > > > > Interesting. I guess I should fix this to only drop the request in > > case there's at least one self-managed wiphy. > > Could you point me to the hwsim test that failed for you? I don't think it was a specific test case - the message seems to have come during boot. OTOH, I also reverted some of Eliad's patches, so perhaps I should retest without those? > Also where is that message coming from? I don't see it in wpa_s or the kernel. I have no idea! I can't even explain where the -7 (-E2BIG) came from! johannes