Message-ID: <1422904939.8755.3.camel@sipsolutions.net> (sfid-20150202_202227_916955_C0D688E0)
Subject: Re: [PATCH] ath10k: Replace ioread with wmb for data sync
From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Oh <poh@codeaurora.org>
Cc: Peter Oh <poh@qca.qualcomm.com>, linux-wireless@vger.kernel.org,
	Bob Copeland <me@bobcopeland.com>, ath10k@lists.infradead.org
Date: Mon, 02 Feb 2015 20:22:19 +0100
In-Reply-To: <54CFCCCF.900@codeaurora.org>
References: <1422311118-11320-1-git-send-email-poh@qca.qualcomm.com>
	 <20150127213349.GA24933@localhost> <54C824DC.5080804@qca.qualcomm.com>
	 <20150128043005.GB24933@localhost> <54C875FD.3070101@qca.qualcomm.com>
	 (sfid-20150128_064104_435635_7E681844) <1422430643.1973.1.camel@sipsolutions.net>
	 <54CC0B71.9050301@codeaurora.org>
	 <1422882133.1930.10.camel@sipsolutions.net>
	 <54CFB4F4.1070807@qca.qualcomm.com>
	 <1422903279.8755.1.camel@sipsolutions.net> <54CFCCCF.900@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org


> > You basically have the following sequence:
> >
> > iowrite()
> > ioread()
> >
> > If you look, you'll see that iowrite() is actually done (or should be,
> > or perhaps with appropriate syncs) on an uncached mapping.
> since it's mmio, iowrite will be map to write, not out which is cached 
> mapping.
> That's why we address "posted write" here.
> If it's un-cached mapping which is volatile, we don't even need ioread.

No, this isn't true - "posted write" in the context of this discussion
is about the PCIe bus. Memory writes that go through cache aren't
referred to as "posted writes", those are just (cached) memory writes.

> >   As a result,
> > the only thing you care about here is the PCIe bus, not the CPU cache
> > flush. And from there on that's just a question of PCIe bus semantics.
> So how does ioread guarantee PCIe bus transaction done?

That's how PCIe works, operations are serialized, and read() has to wait
for a response from the device (but write doesn't - which is "posted
write")

johannes