Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:41629 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbbC0MmB (ORCPT ); Fri, 27 Mar 2015 08:42:01 -0400 From: Kalle Valo To: Michal Kazior CC: Marek Puzyniak , linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [PATCH v4 1/6] ath10k: unify tx mode and dispatch References: <1426849379-7562-1-git-send-email-marek.puzyniak@tieto.com> <1426849379-7562-2-git-send-email-marek.puzyniak@tieto.com> Date: Fri, 27 Mar 2015 14:41:44 +0200 In-Reply-To: (Michal Kazior's message of "Thu, 26 Mar 2015 11:03:08 +0100") Message-ID: <87wq227gtz.fsf@kamboji.qca.qualcomm.com> (sfid-20150327_134207_299111_0F6D3153) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > On 26 March 2015 at 10:27, Michal Kazior wrote: >> On 20 March 2015 at 12:02, Marek Puzyniak wrote: >>> From: Michal Kazior >>> >>> There are a few different tx paths depending on >>> firmware and frame itself. >>> >>> Creating a uniform decision will make it possible >>> to switch between different txmode easier, both >>> for testing and for future features as well. >>> >>> Signed-off-by: Michal Kazior >>> Signed-off-by: Marek Puzyniak >> [...] >> >> This patch apparently breaks AP operation. I need to investigate this. > > Ok - htt.freq missed clearing and in some cases it contained garbage > leading to HTT discarding packets. > > @Kalle: I've posted a patch `ath10k: clear htt.freq` which addresses > the problem separately. Please apply it _before_ you apply TDLS > patches (which are fine, including this patch) to avoid breakage > in-between commits. Ack, I'll do that. Thanks for fixing this. -- Kalle Valo