Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:54938 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbbCCKGg (ORCPT ); Tue, 3 Mar 2015 05:06:36 -0500 Message-ID: <1425377192.2450.34.camel@sipsolutions.net> (sfid-20150303_110640_307763_C786E6ED) Subject: Re: [PATCH v2 3/4] mac80211: initialize rate control earlier for tdls station From: Johannes Berg To: Arik Nemtsov Cc: Marek Puzyniak , Arik Nemtsov , "linux-wireless@vger.kernel.org" , ath10k@lists.infradead.org Date: Tue, 03 Mar 2015 11:06:32 +0100 In-Reply-To: (sfid-20150303_110220_998365_295112A3) References: <1424850911-21017-1-git-send-email-marek.puzyniak@tieto.com> <1424850911-21017-4-git-send-email-marek.puzyniak@tieto.com> <1425041427.1960.1.camel@sipsolutions.net> <1425374299.2450.18.camel@sipsolutions.net> (sfid-20150303_110220_998365_295112A3) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2015-03-03 at 12:02 +0200, Arik Nemtsov wrote: > On Tue, Mar 3, 2015 at 11:18 AM, Johannes Berg > wrote: > > On Sun, 2015-03-01 at 10:21 +0200, Arik Nemtsov wrote: > > > >> > Arik, you have a similar patch handling only NSS. Does this one look > >> > fine to you, and would it solve the problem your other patch solved? > >> > >> Well currently iwlmvm requires the NSS to be set before > >> IEEE80211_STA_ASSOC (earlier), so this doesn't help directly. > >> I could change mvm a bit to make it work, but I don't really see a > >> good reason for it :) > >> > >> The patch looks good. Shouldn't introduce new issues (at least for iwlwifi). > > > > Ok, thanks. Do you think it would be possible to move all of this before > > ASSOC? > > We can probably move his rate_control_rate_init() to assoc, since we have this: And doing so would also address the nss problem, right? IIRC that's done in the rate control init inline. johannes