Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:37040 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbbCCKCW (ORCPT ); Tue, 3 Mar 2015 05:02:22 -0500 Received: by labhs14 with SMTP id hs14so36269070lab.4 for ; Tue, 03 Mar 2015 02:02:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1425374299.2450.18.camel@sipsolutions.net> References: <1424850911-21017-1-git-send-email-marek.puzyniak@tieto.com> <1424850911-21017-4-git-send-email-marek.puzyniak@tieto.com> <1425041427.1960.1.camel@sipsolutions.net> <1425374299.2450.18.camel@sipsolutions.net> From: Arik Nemtsov Date: Tue, 3 Mar 2015 12:02:05 +0200 Message-ID: (sfid-20150303_110238_562566_6DAD47EE) Subject: Re: [PATCH v2 3/4] mac80211: initialize rate control earlier for tdls station To: Johannes Berg Cc: Marek Puzyniak , Arik Nemtsov , "linux-wireless@vger.kernel.org" , ath10k@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Mar 3, 2015 at 11:18 AM, Johannes Berg wrote: > On Sun, 2015-03-01 at 10:21 +0200, Arik Nemtsov wrote: > >> > Arik, you have a similar patch handling only NSS. Does this one look >> > fine to you, and would it solve the problem your other patch solved? >> >> Well currently iwlmvm requires the NSS to be set before >> IEEE80211_STA_ASSOC (earlier), so this doesn't help directly. >> I could change mvm a bit to make it work, but I don't really see a >> good reason for it :) >> >> The patch looks good. Shouldn't introduce new issues (at least for iwlwifi). > > Ok, thanks. Do you think it would be possible to move all of this before > ASSOC? We can probably move his rate_control_rate_init() to assoc, since we have this: /* * TDLS -- everything follows authorized, but * only becoming authorized is possible, not * going back */ if (set & BIT(NL80211_STA_FLAG_AUTHORIZED)) { set |= BIT(NL80211_STA_FLAG_AUTHENTICATED) | BIT(NL80211_STA_FLAG_ASSOCIATED); mask |= BIT(NL80211_STA_FLAG_AUTHENTICATED) | BIT(NL80211_STA_FLAG_ASSOCIATED); }