Return-path: Received: from mail-ig0-f175.google.com ([209.85.213.175]:34912 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbbCOIun convert rfc822-to-8bit (ORCPT ); Sun, 15 Mar 2015 04:50:43 -0400 MIME-Version: 1.0 In-Reply-To: <20150313151301.GJ5264@atomide.com> References: <1426162154-8716-1-git-send-email-eliad@wizery.com> <1426162154-8716-7-git-send-email-eliad@wizery.com> <20150313151301.GJ5264@atomide.com> Date: Sun, 15 Mar 2015 10:50:42 +0200 Message-ID: (sfid-20150315_095052_234022_75116C96) Subject: Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data From: Eliad Peller To: Tony Lindgren Cc: "linux-wireless@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Enric Balletbo i Serra , Javier Martinez Canillas , Sekhar Nori , Kevin Hilman , Luciano Coelho Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Mar 13, 2015 at 5:13 PM, Tony Lindgren wrote: > * Eliad Peller [150312 05:10]: >> Now that we have wlcore device-tree bindings in place >> (for both wl12xx and wl18xx), remove the legacy >> wl12xx_platform_data struct, and move its members >> into the platform device data (that is passed to wlcore) >> >> Davinci 850 is the only platform that still set >> the platform data in the legacy way (and doesn't >> have DT bindings), so remove the relevant >> code/Kconfig option from the board file (as suggested >> by Sekhar Nori) >> >> Signed-off-by: Luciano Coelho >> Signed-off-by: Eliad Peller >> --- >> arch/arm/mach-davinci/Kconfig | 11 --- >> arch/arm/mach-davinci/board-da850-evm.c | 113 ------------------------- >> drivers/net/wireless/ti/wilink_platform_data.c | 25 ------ >> drivers/net/wireless/ti/wl12xx/main.c | 19 ++--- >> drivers/net/wireless/ti/wlcore/boot.c | 1 - >> drivers/net/wireless/ti/wlcore/main.c | 4 +- >> drivers/net/wireless/ti/wlcore/sdio.c | 75 +++++----------- >> drivers/net/wireless/ti/wlcore/wlcore_i.h | 8 +- >> include/linux/wl12xx.h | 25 ------ >> 9 files changed, 36 insertions(+), 245 deletions(-) > > I got a build error related to the SPI driver with this series, probably > need to update this patch: > > drivers/net/wireless/ti/wlcore/spi.c: In function ‘wl1271_probe’: > drivers/net/wireless/ti/wlcore/spi.c:334:11: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ > pdev_data.pdata = dev_get_platdata(&spi->dev); > ^ > drivers/net/wireless/ti/wlcore/spi.c:335:16: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ > if (!pdev_data.pdata) { > yeah, i missed it :/ looks like there's no platform that defines platform data for it. i'll replace the dev_get_platdata() with a function that only parses the clock-frequency properties (the irq is taken in this case from the spi_device). (or maybe i should just drop it, as no one actually uses it?) thanks, Eliad.