Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:37813 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbbC3Jer (ORCPT ); Mon, 30 Mar 2015 05:34:47 -0400 Received: by wiaa2 with SMTP id a2so120238608wia.0 for ; Mon, 30 Mar 2015 02:34:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1427705012.26117.11.camel@sipsolutions.net> References: <1427433674-5745-1-git-send-email-miaoqing@qca.qualcomm.com> <1427705012.26117.11.camel@sipsolutions.net> From: Krishna Chaitanya Date: Mon, 30 Mar 2015 15:04:26 +0530 Message-ID: (sfid-20150330_113452_591422_DEDA1261) Subject: Re: [PATCH] mac80211: fix failed to set smps To: Johannes Berg Cc: miaoqing@qti.qualcomm.com, John Linville , linux-wireless , ath9k-devel@qca.qualcomm.com Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Mar 30, 2015 at 2:13 PM, Johannes Berg wrote: > On Fri, 2015-03-27 at 13:21 +0800, miaoqing@qti.qualcomm.com wrote: >> From: Miaoqing Pan >> >> Signed-off-by: Miaoqing Pan > > Since you give no commit log, I can only guess what you're trying to do, > but I suppose you need to use "echo -n" instead of "echo". Johannes, We had this discussion earlier also, i still strongly feel all cases must work with "echo" by default, as people are not that familiar to use "echo -n".