Return-path: Received: from mail-we0-f171.google.com ([74.125.82.171]:37860 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbbCAWXn (ORCPT ); Sun, 1 Mar 2015 17:23:43 -0500 Received: by wesw55 with SMTP id w55so29964667wes.4 for ; Sun, 01 Mar 2015 14:23:41 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1425238304-498-19-git-send-email-emmanuel.grumbach@intel.com> References: <1425238186.30202.5.camel@egrumbacBox> <1425238304-498-19-git-send-email-emmanuel.grumbach@intel.com> From: Julian Calaby Date: Mon, 2 Mar 2015 09:23:21 +1100 Message-ID: (sfid-20150301_232347_376703_DA53FA8A) Subject: Re: [PATCH 19/31] iwlwifi: mvm: don't iterate interfaces to disconnect in net-detect To: Emmanuel Grumbach Cc: linux-wireless , Luciano Coelho Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Emmanuel, On Mon, Mar 2, 2015 at 6:31 AM, Emmanuel Grumbach wrote: > From: Luciano Coelho > > We shouldn't call iwl_mvm_d3_disconnect_iter() on the running > interfaces when we are woken up due to net-detect, because it doesn't > make sense. Additionally, this seems to set the > IEEE80211_SDATA_DISCONNECT_RESUME flag that will cause a disconnection > on the next resume (if a normal WoWLAN is used). > > To solve this, skip the iteration loop when net-detect is set. > > Reported-by: Samuel Tan > Reviewed-by: Johannes Berg > Signed-off-by: Emmanuel Grumbach Shouldn't this be signed off by Luciano too? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/