Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:35889 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbbCKKFt (ORCPT ); Wed, 11 Mar 2015 06:05:49 -0400 Received: by wiwh11 with SMTP id h11so27123334wiw.1 for ; Wed, 11 Mar 2015 03:05:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <2121942.zIG9BfPsTV@wuerfel> References: <1425915402-10012-1-git-send-email-eliad@wizery.com> <1425915402-10012-2-git-send-email-eliad@wizery.com> <2121942.zIG9BfPsTV@wuerfel> Date: Wed, 11 Mar 2015 11:05:47 +0100 Message-ID: (sfid-20150311_110555_313522_CD8A1AA8) Subject: Re: [PATCH v5 2/3] wl18xx: add basic device-tree support From: Javier Martinez Canillas To: Arnd Bergmann Cc: "linux-arm-kernel@lists.infradead.org" , Eliad Peller , "devicetree@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-omap@vger.kernel.org" , Ido Yariv Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello Arnd, On Wed, Mar 11, 2015 at 10:51 AM, Arnd Bergmann wrote: > On Wednesday 11 March 2015 01:34:19 Javier Martinez Canillas wrote: >> > + >> > +static struct wl12xx_platform_data * >> > +wlcore_get_platform_data(struct device *dev) >> > +{ >> > + struct wl12xx_platform_data *pdata; >> > + >> > + /* first, look for DT data */ >> >> I thought it was the opposite, that platform data should over-rule DT. >> That way you can still use the data filled in >> arch/arm/mach-omap2/pdata-quirks.c even after the driver supports your >> new DT binding. > > No, the pdata-quirks stuff for this driver must die, it was a hack > that only exists because we previously could not attach data to an > sdio function. > Ok sorry, I misunderstood and thought that the output from the discussion in patch 3/3 was that the pdata could not still be removed due not having a way to configure the clocks for wl12xx. I totally agree with removing the pdata on this driver, in fact I would go an just remove all the remaining OMAP2+ board files and pdata-quirks completely. Most OMAP2+ boards have been converted to DT years ago and if someone really cares about mainline support for these boards, they can add a DTS and DT bindings for the drivers that still needed like this one. Best regards, Javier