Return-path: Received: from muru.com ([72.249.23.125]:36446 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbbCKPQo (ORCPT ); Wed, 11 Mar 2015 11:16:44 -0400 Date: Wed, 11 Mar 2015 08:11:38 -0700 From: Tony Lindgren To: Eliad Peller Cc: Javier Martinez Canillas , Arnd Bergmann , "linux-wireless@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sekhar Nori , Kevin Hilman Subject: Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings Message-ID: <20150311151138.GU5264@atomide.com> (sfid-20150311_161648_731414_9108C8C1) References: <1425915402-10012-1-git-send-email-eliad@wizery.com> <6286151.8rcX893TN6@wuerfel> <2353601.si5uCETVn2@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: * Eliad Peller [150311 06:39]: > On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas > wrote: > > On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann wrote: > >> On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: > >>> > >>> Right now it seems that all boards in mainline with a WiLink6 part are > >>> using internal clocks. So as a first step I think that adding an > >>> optional refclock-frequency and tcxoclock-frequency properties should > >>> be enough. > >>> > >>> It would be good if the driver supports getting the refclock and > >>> tcxoclock from an external provider in case a board gets these from > >>> external clocks but that can be done as a followup if there are boards > >>> in the future using that design. > >>> > >>> But please bear in mind that I'm not familiar with the clock handling > >>> in WiLink6 since the WiLink8 part used in the IGEP boards does not > >>> need these clocks and I only looked at Luciano's previous patches and > >>> the WiLink today driver today. So it would be good if Eliad can double > >>> check my assumptions to see if those are correct. > >> > sounds right. that's what i know as well. > > >> Sounds good. I'd also be fine with not implementing the case for > >> external clocks in the code until we need (and can test) it, but > >> I think it should be specified in the binding from the start. > >> > > Agreed. > > > great. so i'll implement the internal clocks case only. OK great sounds good to me also. Regards, Tony