Return-path: Received: from hofr.at ([212.69.189.236]:35473 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbbCLHcc (ORCPT ); Thu, 12 Mar 2015 03:32:32 -0400 Date: Thu, 12 Mar 2015 08:32:30 +0100 From: Nicholas Mc Guire To: Sergei Shtylyov Cc: Nicholas Mc Guire , Kalle Valo , Valdis.Kletnieks@vt.edu, Bj??rn Mork , Jeff Haran , Pat Erley , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function Message-ID: <20150312073230.GA32014@opentech.at> (sfid-20150312_083252_576587_AC041794) References: <1426100519-20636-1-git-send-email-hofrat@osadl.org> <5500A58F.3040904@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5500A58F.3040904@cogentembedded.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 11 Mar 2015, Sergei Shtylyov wrote: > Hello. > > On 03/11/2015 10:01 PM, Nicholas Mc Guire wrote: > >> Putting code into the parameter list of wait_event_timeout() might be >> legal C-code but not really readable - the "inline" code is simply >> moved into a function and that passed to wait_event_timeout() as the >> condition. As wait_event_timeout will always return >= 0 the following >> timeout check is fixed up to ret == 0 . > >> Signed-off-by: Nicholas Mc Guire > [...] > >> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c >> index e8cc19f..a7a12cc 100644 >> --- a/drivers/net/wireless/ath/ath10k/mac.c >> +++ b/drivers/net/wireless/ath/ath10k/mac.c >> @@ -4463,11 +4463,25 @@ static int ath10k_set_rts_threshold(struct ieee80211_hw *hw, u32 value) >> return ret; >> } >> >> +static bool check_htt_state(struct ath10k *ar, bool *skip) >> +{ >> + bool empty; >> + >> + spin_lock_bh(&ar->htt.tx_lock); >> + empty = (ar->htt.num_pending_tx == 0); >> + spin_unlock_bh(&ar->htt.tx_lock); >> + >> + *skip = (ar->state == ATH10K_STATE_WEDGED) || >> + test_bit(ATH10K_FLAG_CRASH_FLUSH, >> + &ar->dev_flags); >> + return (empty || *skip); > > Parens not needed here. > Thanks - will see what else I forgot and then repost a cleaned up version. thx! hofrat