Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:58330 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbbCWIWl (ORCPT ); Mon, 23 Mar 2015 04:22:41 -0400 Message-ID: <550FCD16.6030809@ti.com> (sfid-20150323_092247_223222_7163E3BF) Date: Mon, 23 Mar 2015 13:51:42 +0530 From: Sekhar Nori MIME-Version: 1.0 To: Eliad Peller CC: "linux-wireless@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , Tony Lindgren , Enric Balletbo i Serra , Javier Martinez Canillas , Kevin Hilman , Luciano Coelho , Ido Yariv Subject: Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data References: <1426696710-6891-1-git-send-email-eliad@wizery.com> <1426696710-6891-7-git-send-email-eliad@wizery.com> <550FC60F.4050206@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Monday 23 March 2015 01:36 PM, Eliad Peller wrote: > hi Sekhar, > > On Mon, Mar 23, 2015 at 9:51 AM, Sekhar Nori wrote: >> + Ido >> >> On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: >>> Now that we have wlcore device-tree bindings in place >>> (for both wl12xx and wl18xx), remove the legacy >>> wl12xx_platform_data struct, and move its members >>> into the platform device data (that is passed to wlcore) >>> >>> Davinci 850 is the only platform that still set >>> the platform data in the legacy way (and doesn't >>> have DT bindings), so remove the relevant >>> code/Kconfig option from the board file (as suggested >>> by Sekhar Nori) >>> >>> Since no one currently uses wlcore_spi, simply remove its >>> platform data support (DT bindings will have to be added >>> if someone actually needs it) >>> >>> Signed-off-by: Luciano Coelho >>> Signed-off-by: Eliad Peller >>> --- >>> v7: >>> * fix spi compilation (Tony) >>> * remove irq/irq_trigger from wlcore_platdev_data (they are >>> being passed separately) >>> >>> arch/arm/mach-davinci/Kconfig | 11 --- >>> arch/arm/mach-davinci/board-da850-evm.c | 113 ------------------------- >>> drivers/net/wireless/ti/wilink_platform_data.c | 25 ------ >>> drivers/net/wireless/ti/wl12xx/main.c | 19 ++--- >>> drivers/net/wireless/ti/wlcore/boot.c | 1 - >>> drivers/net/wireless/ti/wlcore/main.c | 4 +- >>> drivers/net/wireless/ti/wlcore/sdio.c | 76 +++++------------ >>> drivers/net/wireless/ti/wlcore/spi.c | 6 +- >>> drivers/net/wireless/ti/wlcore/wlcore_i.h | 6 +- >>> include/linux/wl12xx.h | 25 ------ >>> 10 files changed, 35 insertions(+), 251 deletions(-) >> >> The patch looks good to me, but it will be nice to know to which base it >> applies cleanly. I tried applying to v4.0-rc1 and linux-next and both >> failed. >> > The patchset was rebased on top of v4.0-rc4. > (Note that you'll have to apply the whole series, as this patch relies > on some intermediate changes done by the previous patches in the > patchset) I was applying the whole series, but over v4.0-rc1 :) Its best to mention the baseline in cover-letter itself. The DA850 related changes in the patch look good to me. Acked-by: Sekhar Nori Thanks, Sekhar