Return-path: Received: from mail-la0-f44.google.com ([209.85.215.44]:33079 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbbESFQy (ORCPT ); Tue, 19 May 2015 01:16:54 -0400 Received: by lagr1 with SMTP id r1so6041224lag.0 for ; Mon, 18 May 2015 22:16:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <555AC172.4040507@lwfinger.net> References: <55575AC8.2060301@lwfinger.net> <5557844B.4040108@lwfinger.net> <55586D8D.7040407@gmail.com> <555A05DC.8080704@lwfinger.net> <555AC172.4040507@lwfinger.net> Date: Tue, 19 May 2015 08:16:52 +0300 Message-ID: (sfid-20150519_071824_447031_D33EC00B) Subject: Re: kernel page fault in r8712u From: Haggai Eran To: Larry Finger Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19 May 2015 at 07:52, Larry Finger wrote: > I checked the driver with Smatch and found a couple of array problems. These > likely won't be the problem, but try the attached patches anyway. I tried the patches. The first one prevents the driver from working. I think the smatch warning may be a false positive, because HWXMIT_ENTRY is checked specifically for values 4 and 5 in an if statement. The second patch doesn't hurt, but it didn't solve the issue.