Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242AbbEZQf4 (ORCPT ); Tue, 26 May 2015 12:35:56 -0400 Date: Tue, 26 May 2015 09:35:55 -0700 From: Greg KH To: Joe Perches Cc: Sudip Mukherjee , Dan Carpenter , devel@driverdev.osuosl.org, Sudip Mukherjee , linux-wireless@vger.kernel.org, Stable , netdev@vger.kernel.org, Haggai Eran , Arek Rusniak , Larry Finger Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync() Message-ID: <20150526163555.GA9685@kroah.com> (sfid-20150526_183604_703425_B4615D4C) References: <556268BC.5050807@lwfinger.net> <20150525091737.GQ4150@mwanda> <1432575448.2846.63.camel@perches.com> <20150526044611.GA3465@sudip-PC> <1432616108.2846.83.camel@perches.com> <20150526050212.GC3465@sudip-PC> <1432616879.2846.86.camel@perches.com> <20150526141401.GC21573@kroah.com> <1432651739.2846.93.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1432651739.2846.93.camel@perches.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: > On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote: > > On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: > > > As far as I understand, the Eudyptula Challenge list has > > > internal mechanisms to nominally review patches before some > > > patch is submitted to lkml. > > > > No it does not. > > That's not quite what was described to me by someone behind the > email address: > "Little Penguin " back in August. > > What I understood from that email was there is a qualifying > formatting component to the challenge and then patches were to be > sent to maintainers and lists. Hm, I don't know then, but from what I have seen, the tasks that send patches to the kernel are not pre-reviewed by anyone. If they were, the quality level of the patches we get here would have been much higher :) > > > The main point is that patches shouldn't be applied without > > > being submitted to a more widely read list. > > > > I take the blame for any problems with Outreachy patches. > > Are you going to change any procedure associated to these > Outreachy patches? 2 bugs out of 900? Nah, I think that's good odds. Also, the outreachy patch process would overwhelm everyone else on the list, it's really high volume during the application phase, I'd prefer it to stick with the mentors that wish to help out with the process. If you and/or Dan, or anyone else wishes to help out with this, I would really appreciate it. But I don't think that forcing them to post to the driverdevel list is a good idea. thanks, greg k-h