Return-path: Received: from mail-ob0-f169.google.com ([209.85.214.169]:32883 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754078AbbESOzF convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2015 10:55:05 -0400 Received: by obblk2 with SMTP id lk2so14172136obb.0 for ; Tue, 19 May 2015 07:55:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1432020176-17343-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1432020176-17343-1-git-send-email-u.kleine-koenig@pengutronix.de> Date: Tue, 19 May 2015 16:55:04 +0200 Message-ID: (sfid-20150519_165510_687199_12F63A45) Subject: Re: [PATCH] NFC: PN544: use flags argument of devm_gpiod_get to set direction From: Linus Walleij To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Samuel Ortiz , Lauro Ramos Venancio , Aloisio Almeida Jr , Robert Dolca , linux-wireless , Sascha Hauer , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 19, 2015 at 9:22 AM, Uwe Kleine-König wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Use this to simplify the driver. Furthermore this is one caller less > that stops us making the flags argument to gpiod_get*() mandatory. > > While touching this also do some minor coding style fixes. > > Fixes: 0a5942c8e148 ("NFC: Add ACPI support for NXP PN544") As noted on earlier patches: maybe this Fixes: is a bit aggressive. > Signed-off-by: Uwe Kleine-König Anyways: Reviewed-by: Linus Walleij Yours, Linus Walleij