Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:35353 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbbEKRsR convert rfc822-to-8bit (ORCPT ); Mon, 11 May 2015 13:48:17 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 2/2] adm8211: fix the possible pci cache line sizes inside switch-case From: Okash Khawaja In-Reply-To: Date: Mon, 11 May 2015 18:48:11 +0100 Cc: Kalle Valo , "joe@perches.com" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-Id: <4C95B6D2-3A68-4360-BE3C-5264DD0ED8DF@gmail.com> (sfid-20150511_194838_607288_88796C0D) References: <20150505224020.GA3805@bytefire-computer> <87wq0ms3mv.fsf@kamboji.qca.qualcomm.com> <20150506063241.GA3042@bytefire-computer> <87k2wflj7p.fsf@kamboji.qca.qualcomm.com> <2CBE2DDF-92E5-45C9-95F8-C5CF918D12D9@gmail.com> <87vbfzjt4t.fsf@kamboji.qca.qualcomm.com> To: Jonas Gorski Sender: linux-wireless-owner@vger.kernel.org List-ID: > On 11 May 2015, at 14:24, Jonas Gorski wrote: > > Hi, > >> On Mon, May 11, 2015 at 12:38 PM, Kalle Valo wrote: >> Okash Khawaja writes: >> >>> Sure, I'll create v2 of the patch with updated commit log. >>> >>> Since it's part of a patch set, do you want me to send both the >>> patches in the patch set together as v2 or just this patch? >> >> Please resend the whole patchset as v2, less problems that way. > > If you are sending a v2 anyway, I'd suggest using decimal values for > the cases, as cache line sizes are usually given in decimal anyway. So > just drop the "0x" instead of converting the values ;-) > > > Jonas Jonas, I had already sent the updated patch by the time I received your email. Is there a convention around this? Thanks