Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:47467 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbbEYKMY (ORCPT ); Mon, 25 May 2015 06:12:24 -0400 Date: Mon, 25 May 2015 13:12:07 +0300 From: Dan Carpenter To: Vaishali Thakkar Cc: Haggai Eran , Greg KH , Sudip Mukherjee , Larry Finger , Arek Rusniak , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Stable , devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync() Message-ID: <20150525101207.GC22558@mwanda> (sfid-20150525_121234_479645_A591A3E0) References: <1432415812-1285-1-git-send-email-Larry.Finger@lwfinger.net> <556268BC.5050807@lwfinger.net> <20150525091737.GQ4150@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, May 25, 2015 at 03:07:08PM +0530, Vaishali Thakkar wrote: > I am sorry for those patches. It was me who introduced those bugs. Yes, it > was sent during Outreachy process. But it was my mistake as a newbie. May > be I should have taken care of interrupt mode thing. > > I would like to fix it if someone is not doing it. Sorry again. I will take > care of these things in my future patches. No, it's not your fault for making mistakes. We *expect* newbies to make mistakes. It's Greg's fault for merging these when they weren't sent to the list or to the other maintainers. But Greg knows I'm annoyed already since we have been dealing with the fallout for months and I always make sure to complain whenever I have a chance. /me shakes a fist! Grrr.... :P regards, dan carpenter