Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:58679 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbbEZN5v (ORCPT ); Tue, 26 May 2015 09:57:51 -0400 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: carl9170: match wait_for_completion_timeout return type From: Kalle Valo In-Reply-To: <1431454718-23701-1-git-send-email-hofrat@osadl.org> To: Nicholas Mc Guire Cc: Christian Lamparter , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Message-Id: <20150526105335.0AEF81416BB@smtp.codeaurora.org> (sfid-20150526_155848_557706_A8EE9FEE) Date: Tue, 26 May 2015 10:53:35 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > Return type of wait_for_completion_timeout is unsigned long not int. > An appropriately named unsigned long is added, and the assignments > as well as error checking fixed up. > > API conformance testing for completions with coccinelle spatches are being > used to locate API usage inconsistencies: > ./drivers/net/wireless/ath/carl9170/usb.c:675 > int return assigned to unsigned long > > Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, > CONFIG_CARL9170=m > > Patch is against 4.1-rc3 (localversion-next is -next-20150512) > > Signed-off-by: Nicholas Mc Guire > Acked-by: Christian Lamparter Thanks, applied to wireless-drivers-next.git. Kalle Valo