Return-path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:35012 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbbEIJLr (ORCPT ); Sat, 9 May 2015 05:11:47 -0400 Received: by widdi4 with SMTP id di4so54387531wid.0 for ; Sat, 09 May 2015 02:11:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87pp6bp6jy.fsf@kamboji.qca.qualcomm.com> References: <1430841518-3932-1-git-send-email-ap420073@gmail.com> <87pp6bp6jy.fsf@kamboji.qca.qualcomm.com> Date: Sat, 9 May 2015 18:11:45 +0900 Message-ID: (sfid-20150509_111150_519483_794ADBA5) Subject: Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code. From: Taehee Yoo To: Kalle Valo Cc: Larry Finger , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2015-05-08 22:01 GMT+09:00 Kalle Valo : > Taehee Yoo writes: > >> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status(). >> Initialization routine set REG_BCN_MAX_ERR to 0xFF. >> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value. >> so i remove this code. >> >> 2. Remove rtl92c_init_beacon_max_error's parameter. >> because parameter "infra_mode" is not used. >> >> Signed-off-by: Taehee Yoo > > Please split the patches into two. Having a numbered list of changes in > the commit log is a strong indication that the patch should be split > into smaller patches. > > -- > Kalle Valo Thank you for your review! I'll resend two patchs.